Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/11242#discussion_r56727449
--- Diff: core/src/main/scala/org/apache/spark/rdd/UnionRDD.scala ---
@@ -62,7 +64,23 @@ class UnionRDD[T: ClassTag](
var rdds: Seq[RDD[T]])
extends RDD[T](sc, Nil) { // Nil since we implement getDependencies
+ // Evaluate partitions in parallel. Partitions of each rdd will be
cached by the `partitions`
+ // val in `RDD`.
+ private[spark] lazy val parallelPartitionEval: Boolean = {
+ val threshold = conf.getInt("spark.rdd.parallelListingThreshold", 10)
+ if (threshold > 0 && rdds.length > threshold) {
+ val parArray = rdds.toParArray
+ parArray.tasksupport = new ForkJoinTaskSupport(
+ new ForkJoinPool(math.min(threshold, 8)))
--- End diff --
The current code allows the user to turn parallelism off (thresh=0) or to
control when parallel processing happens, but limits execution to a maximum of
8 threads. I think that's pretty reasonable.
Your suggestion allows setting the number of threads, but not controlling
when execution happens in parallel. But controlling the number of threads is
not the important part. At a minimum, users should be able to keep the current
behavior.
If users need to set the number of threads, we can do that in a later patch
when necessary. Otherwise, I think the current patch is the right way to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
