Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11750#discussion_r56421080
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -167,7 +170,7 @@ abstract class ExternalCatalog {
* @param name name of the function
* @param className fully qualified class name, e.g.
"org.apache.spark.util.MyFunc"
*/
-case class CatalogFunction(name: String, className: String)
+case class CatalogFunction(name: FunctionIdentifier, className: String)
--- End diff --
`catalogFunc.name.funcName` is kind of weird (we do not need to change it
right now).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
