Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/11831#discussion_r56762251
--- Diff:
core/src/main/java/org/apache/spark/api/java/function/DoubleFunction.java ---
@@ -23,5 +23,5 @@
* A function that returns Doubles, and can be used to construct
DoubleRDDs.
*/
public interface DoubleFunction<T> extends Serializable {
- public double call(T t) throws Exception;
+ double call(T t) throws Exception;
--- End diff --
Thank you for you review. Yes, this PR removes unnecessary keywords due to
their default meaning in Java language. Also, I agree with you that sometimes
*explicitly* written code (e.g. *interface method*) also is good for
emphasizing the meaning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
