Github user joan38 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11747#discussion_r56767638
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala ---
@@ -255,21 +262,19 @@ class SparkListenerSuite extends SparkFunSuite with
LocalSparkContext with Match
taskInfoMetrics.map(_._2.executorDeserializeTime),
stageInfo + " executorDeserializeTime")
- /* Test is disabled (SEE SPARK-2208)
if (stageInfo.rddInfos.exists(_.name == d4.name)) {
checkNonZeroAvg(
taskInfoMetrics.map(_._2.shuffleReadMetrics.get.fetchWaitTime),
stageInfo + " fetchWaitTime")
}
- */
taskInfoMetrics.foreach { case (taskInfo, taskMetrics) =>
- taskMetrics.resultSize should be > (0L)
+ taskMetrics.resultSize should be > 0L
if (stageInfo.rddInfos.exists(info => info.name == d2.name ||
info.name == d3.name)) {
- taskMetrics.inputMetrics should not be ('defined)
- taskMetrics.outputMetrics should not be ('defined)
+ taskMetrics.inputMetrics should not be 'defined
+ taskMetrics.outputMetrics should not be 'defined
taskMetrics.shuffleWriteMetrics should be ('defined)
- taskMetrics.shuffleWriteMetrics.get.bytesWritten should be > (0L)
+ taskMetrics.shuffleWriteMetrics.get.bytesWritten should be > 0L
--- End diff --
Ah yeah, that's because I usually write:
taskMetrics.shuffleWriteMetrics shouldBe 'defined
instead of:
taskMetrics.shuffleWriteMetrics should be ('defined)
I find it much quicker to write and Idea doesn't warn me on the useless
brackets. Never mind I reverted this.
I just pushed the 25ms version. "Jenkins retest this please"
:stuck_out_tongue_winking_eye:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
