Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11741#discussion_r56770737
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java 
---
    @@ -34,6 +34,7 @@
       protected LinkedList<InternalRow> currentRows = new LinkedList<>();
       // used when there is no column in output
       protected UnsafeRow unsafeRow = new UnsafeRow(0);
    +  private long startTimeMs = System.currentTimeMillis();
    --- End diff --
    
    we should use nanoTime. See 
https://github.com/databricks/scala-style-guide#misc_currentTimeMillis_vs_nanoTime


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to