Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11208#discussion_r56779097
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1934,6 +1934,21 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
}
}
+ test("Star Expansion - CreateStruct and CreateArray") {
+ val structDf = testData2.select("a", "b").as("record")
+ // CreateStruct and CreateArray in aggregateExpressions
+ assert(structDf.groupBy($"a").agg(min(struct($"record.*"))).first() ==
Row(3, Row(3, 1)))
+ assert(structDf.groupBy($"a").agg(min(array($"record.*"))).first() ==
Row(3, Seq(3, 1)))
+
+ // CreateStruct and CreateArray in project list (unresolved alias)
+ assert(structDf.select(struct($"record.*")).first() == Row(Row(1, 1)))
+ assert(structDf.select(array($"record.*")).first().getAs[Seq[Int]](0)
=== Seq(1, 1))
+
+ // CreateStruct and CreateArray in project list (alias)
--- End diff --
how about we add another case: `Generate` and `ScriptTransform`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
