Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11737#discussion_r56846172
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -729,7 +729,7 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils
with TestHiveSingleton {
}
test("SPARK-5203 union with different decimal precision") {
- Seq.empty[(Decimal, Decimal)]
+ Seq.empty[(java.math.BigDecimal, java.math.BigDecimal)]
--- End diff --
Are all these decimal related changes because merging `DataFrameHolder` and
`DatasetHolder` breaks compilation, or just because `Decimal` is internal type
and shouldn't be exposed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
