Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11791#discussion_r56874816
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -129,10 +136,9 @@ private[spark] class MemoryStore(
* iterator or call `close()` on it in order to free the storage
memory consumed by the
* partially-unrolled block.
*/
- private[storage] def putIterator(
+ private[storage] def putIteratorAsValues(
--- End diff --
In case it isn't obvious from the diff, the main change in this file is to
split `putIterator` into two separate methods, `putIteratorAsValues` and
`putIteratorAsBytes`.
It's possible that there's some opportunity to reduce code duplication
here, but unless we can come up with an obvious and simple approach I would
prefer to defer cleanup to followup patches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
