Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r57028933
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -395,12 +396,19 @@ class Analyzer(
Project(projectList = expanded, p.child)
// If the aggregate function argument contains Stars, expand it.
case a: Aggregate if containsStar(a.aggregateExpressions) =>
- val expanded = a.aggregateExpressions.flatMap {
- case s: Star => s.expand(a.child, resolver)
- case o if containsStar(o :: Nil) => expandStarExpression(o,
a.child) :: Nil
- case o => o :: Nil
- }.map(_.asInstanceOf[NamedExpression])
- a.copy(aggregateExpressions = expanded)
+ if (conf.groupByOrdinal &&
a.groupingExpressions.exists(IntegerIndex.unapply(_).nonEmpty)) {
+ failAnalysis(
+ "Group by position: star is not allowed to use in the select
list " +
+ "when using ordinals in group by")
+ } else {
+ val expanded = a.aggregateExpressions.flatMap {
+ case s: Star => s.expand(a.child, resolver)
+ case u @ UnresolvedAlias(_: Star, _) =>
expandStarExpression(u.child, a.child) :: Nil
--- End diff --
After reading the code, `Project` still has a problem in star expansion:
```scala
val structDf = testData2.select("a", "b").as("record")
structDf.select(hash($"record.*"))
```
Sorry, the previous PR does not cover all the cases. Let me submit a
separate PR to handle all the star expansion. After the fix, we will not issue
a message like:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L444
Of course, if we want to limit the support of star expansion in group by,
we can do it for sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
