Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11663#discussion_r57068173
  
    --- Diff: python/pyspark/ml/param/__init__.py ---
    @@ -17,28 +17,38 @@
     
     from abc import ABCMeta
     import copy
    +import numpy as np
    +import warnings
     
     from pyspark import since
     from pyspark.ml.util import Identifiable
    +from pyspark.mllib.linalg import DenseVector, Vector, _convert_to_vector
     
     
    -__all__ = ['Param', 'Params']
    +__all__ = ['Param', 'Params', 'TypeConverters']
     
     
     class Param(object):
         """
         A param with self-contained documentation.
     
    +    Note: `expectedType` is deprecated and will be removed in 2.1.0, use 
typeConverter instead,
    --- End diff --
    
    I basically just added a period. I think that's all you were suggesting?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to