Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/1582#discussion_r15498592
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/DTParams.scala
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.mllib.tree.configuration
+
+import scala.beans.BeanProperty
+
+import org.apache.spark.annotation.Experimental
+
+/**
+ * :: Experimental ::
+ * Stores configuration options for DecisionTree construction.
+ * @param maxDepth Maximum depth of the tree.
+ * E.g., depth 0 means 1 leaf node; depth 1 means 1
internal node + 2 leaf nodes.
+ * @param maxBins maximum number of bins used for splitting features
+ * @param quantileStrategy algorithm for calculating quantiles
+ * @param maxMemoryInMB maximum memory in MB allocated to histogram
aggregation. Default value is
+ * 128 MB.
+ */
+@Experimental
+abstract class DTParams (
--- End diff --
Should this class be private to mllib.tree? If yes, do we need bean
properties? I am assuming the ```@BeanProperty``` is being used for java
interoperability. But we might not need to expose this class directly to the
users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
