Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11941#discussion_r57366595 --- Diff: pom.xml --- @@ -178,6 +178,9 @@ <test.java.home>${java.home}</test.java.home> <test.exclude.tags></test.exclude.tags> + <!-- Package to use when relocating shaded classes. --> + <spark.shade.packageName>org.spark_project</spark.shade.packageName> --- End diff -- For total avoidance of trouble, is `org.sparkproject` safer? or are you sure underscores are more OK than hyphens? BTW you could consider this PR as a resolution for SPARK-8815 too.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org