GitHub user tedyu opened a pull request:

    https://github.com/apache/spark/pull/11943

    [SPARK-12181] Check Cached unaligned-access capability before using Unsafe

    ## What changes were proposed in this pull request?
    
    For MemoryMode.OFF_HEAP, Unsafe.getInt etc. are used with no restriction.
    
    However, the Oracle implementation uses these methods only if the class 
variable unaligned (commented as "Cached unaligned-access capability") is true, 
which seems to be calculated whether the architecture is i386, x86, amd64, or 
x86_64.
    
    I think we should perform similar check for the use of Unsafe.
    
    ## How was this patch tested?
    
    Unit test suite

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tedyu/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11943
    
----
commit ed7064690de566270ec7dbc02870a3e08dd17f2d
Author: tedyu <yuzhih...@gmail.com>
Date:   2016-03-24T20:37:37Z

    [SPARK-12181] Check Cached unaligned-access capability before using Unsafe

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to