Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11846#discussion_r57409753
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -634,24 +641,26 @@ class Analyzer(
}
}
- /**
- * In many dialects of SQL it is valid to sort by attributes that are
not present in the SELECT
- * clause. This rule detects such queries and adds the required
attributes to the original
- * projection, so that they will be available during sorting. Another
projection is added to
- * remove these attributes after sorting.
- *
- * This rule also resolves the position number in sort references. This
support is introduced
- * in Spark 2.0. Before Spark 2.0, the integers in Order By has no
effect on output sorting.
- * - When the sort references are not integer but foldable expressions,
ignore them.
- * - When spark.sql.orderByOrdinal is set to false, ignore the position
numbers too.
- */
- object ResolveSortReferences extends Rule[LogicalPlan] {
+ /**
+ * In many dialects of SQL it is valid to use ordinal positions in
order/sort by and group by
+ * clauses. This rule is to convert ordinal positions to the
corresponding expressions in the
+ * select list. This support is introduced in Spark 2.0.
+ *
+ * - When the sort references or group by expressions are not integer but
foldable expressions,
+ * just ignore them.
+ * - When spark.sql.orderByOrdinal/spark.sql.groupByOrdinal is set to
false, ignore the position
+ * numbers too.
+ *
+ * Before the release of Spark 2.0, the literals in order/sort by and
group by clauses
+ * have no effect on the results.
+ */
+ object ResolveOrdinalInOrderByAndGroupBy extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
- case s: Sort if !s.child.resolved => s
- // Replace the index with the related attribute for ORDER BY
+ // Replace the index with the related attribute for ORDER BY,
// which is a 1-base position of the projection list.
case s @ Sort(orders, global, child)
- if conf.orderByOrdinal && orders.exists(o =>
IntegerIndex.unapply(o.child).nonEmpty) =>
+ if conf.orderByOrdinal && child.resolved &&
--- End diff --
We can add a `case plan if !plan.childrenResolved => plan` at the beginning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
