Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11553#discussion_r57414462
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
    @@ -49,6 +49,21 @@ private[feature] trait QuantileDiscretizerBase extends 
Params
     
       /** @group getParam */
       def getNumBuckets: Int = getOrDefault(numBuckets)
    +
    +  /**
    +   * Relative error (see approxQuantile documentation for description).  
Must be >= 0.
    +   * By default, the relative error will be in the range [0.001, 0.01]. 
The exact value
    +   * is computed based on the number of buckets, decreasing as the number 
of buckets
    +   * increases. Explicitly setting the relative error will override this 
default calculation.
    +   * @group param
    --- End diff --
    
    Provide a `@see` link to `approxQuantile` 
(https://github.com/apache/spark/blob/13ce10e95401b21fa40ca0bb27ebf9a0bfffe70f/sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala#L66).
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to