Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11953#discussion_r57423498
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -62,6 +62,7 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
extends TreeNode[PlanT
case _ =>
Set.empty[Expression]
}.foldLeft(Set.empty[Expression])(_ union _.toSet)
+ .union(output.filterNot(_.nullable).map(IsNotNull).toSet)
--- End diff --
can we break chains like this down with intermediate variables and
comments? they are becoming fairly difficult to understand.
Also the foldLeft/union ... seems like a pretty inefficient way to run this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
