Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r57465383
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -246,9 +246,7 @@ class StreamingContext private[streaming] (
checkpointDir != null
}
- private[streaming] def initialCheckpoint: Checkpoint = {
- if (isCheckpointPresent) _cp else null
- }
+ private[streaming] def initialCheckpoint: Checkpoint = _cp
--- End diff --
Yes it's functionally equivalent. The method isn't overridden. I suppose
that it's conceivable the logic of `isCheckpointPresent` could change later
though. Other methods have a similar check too. Although it's a no-op change
and small simplification, it doesn't matter in practice to check "if (a !=
null) a else null" Since the purpose here is just typo fixes, I'd stick to that
and not bother with this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
