Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11829#discussion_r57470219
--- Diff: bin/pyspark ---
@@ -49,7 +49,10 @@ if [[ -n "$IPYTHON_OPTS" || "$IPYTHON" == "1" ]]; then
# If IPython options are specified, assume user wants to run IPython
# (for backwards-compatibility)
PYSPARK_DRIVER_PYTHON_OPTS="$PYSPARK_DRIVER_PYTHON_OPTS $IPYTHON_OPTS"
- PYSPARK_DRIVER_PYTHON="ipython"
+ if [ -x "$(command -v jupyter)" ]; then
+ PYSPARK_DRIVER_PYTHON="jupyter"
+ else
+ PYSPARK_DRIVER_PYTHON="ipython"
--- End diff --
@rekhajoshm I keep thinking the test failures are spurious, and clearly
some of them are, but I'm now double-checking that this seemingly simple change
is actually right. Do you not need a closing `fi` after this line? not sure if
it's implicit but was speculating that maybe this is causing a failure in a
mysterious way at the end when Pyspark tests start. Could be a wrong guess.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
