Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11959#discussion_r57506942
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -53,12 +54,19 @@ case class CreateDatabase(
extends NativeDDLCommand(sql) with Logging
case class CreateFunction(
+ databaseName: Option[String],
functionName: String,
alias: String,
resources: Seq[(String, String)],
isTemp: Boolean)(sql: String)
extends NativeDDLCommand(sql) with Logging
+case class DropFunction(
+ functionName: String,
--- End diff --
Because from Hive DDL
[manual](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-Create/Drop/ReloadFunction),
it doesn't explicitly mention database name parameter for drop function.
But from the parser rule, it uses the same parsing rule as create function
DDL command. So it should support database name. Let me add it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
