Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11971#issuecomment-201703258
> LGTM but I wonder if just overriding Thread.run and making it final
wouldn't be enough (the task to run would have to be passed as a Runnable). It
would simplify the code a little bit and you wouldn't need to deal with
reentrant calls, which the current code doesn't seem to need anyway.
Could you clarify it? If overriding `run`, then the whole Thread will be
uninterruptible and this is not what we want.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
