Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11975#discussion_r57517025
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -114,13 +109,52 @@ trait CodegenSupport extends SparkPlan {
protected def doProduce(ctx: CodegenContext): String
/**
- * Consume the columns generated from current SparkPlan, call it's
parent.
+ * Consume the generated columns or row from current SparkPlan, call
it's parent's doConsume().
*/
- final def consume(ctx: CodegenContext, input: Seq[ExprCode], row: String
= null): String = {
- if (input != null) {
- assert(input.length == output.length)
+ final def consume(ctx: CodegenContext, outputVars: Seq[ExprCode], row:
String = null): String = {
+ val inputVars =
+ if (row != null) {
--- End diff --
i was hoping we could remove these branches too. I think it'd require
putting the outputVars and the row into a single class with different
constructors. Anyway we can do that later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
