GitHub user sarutak opened a pull request:

    https://github.com/apache/spark/pull/11990

    [SPARK-14185][SQL][Minor] Make indentation of debug log for generated code 
proper

    ## What changes were proposed in this pull request?
    
    The indentation of debug log output by `CodeGenerator` is weird.
    The first line of the generated code should be put on the next line of the 
first line of the log message.
    
    ```
    16/03/28 11:10:24 DEBUG CodeGenerator: /* 001 */                            
                                                                                
  
    /* 002 */ public java.lang.Object generate(Object[] references) {
    /* 003 */   return new SpecificSafeProjection(references); 
    ...
    ```
    
    After this patch is applied, we get debug log like as follows.
    
    ```
    16/03/28 10:45:50 DEBUG CodeGenerator:                                      
           
    /* 001 */ 
    /* 002 */ public java.lang.Object generate(Object[] references) {
    /* 003 */   return new SpecificSafeProjection(references);
    ...
    ```
    ## How was this patch tested?
    
    Ran some jobs and checked debug logs.
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarutak/spark fix-debuglog-indentation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11990.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11990
    
----
commit 49ac4c87d56da1480ded28f1f42f310807823671
Author: Kousuke Saruta <saru...@oss.nttdata.co.jp>
Date:   2016-03-28T01:48:18Z

    Made indentation of debug log for codegen properly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to