Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1056#discussion_r15526958
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -155,6 +156,23 @@ class DAGScheduler(
         eventProcessActor ! CompletionEvent(task, reason, result, 
accumUpdates, taskInfo, taskMetrics)
       }
     
    +  /**
    +   * Update metrics for in-progress tasks and let the master know that the 
BlockManager is still
    +   * alive. Return true if the driver knows about the given block manager. 
Otherwise, return false,
    +   * indicating that the block manager should re-register.
    +   */
    +  def executorHeartbeatReceived(
    +      execId: String,
    +      taskMetrics: Array[(Long, Int, TaskMetrics)],
    +      blockManagerId: BlockManagerId): Boolean = {
    +    listenerBus.post(SparkListenerExecutorMetricsUpdate(execId, 
taskMetrics))
    +    implicit val timeout = Timeout(30 seconds)
    --- End diff --
    
    Makes sense


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to