GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/12011
[SPARK-14086][SQL] Add DDL commands to ANTLR4 parser
#### What changes were proposed in this pull request?
This PR adds all the current Spark SQL DDL commands to the new ANTLR 4
based SQL parser.
I have found a few inconsistencies in the current commands:
- Function has an alias field. This is actually the class name of the
function.
- Partition specifications should contain nulls in some commands, and
contain `None`s in others.
- `AlterTableSkewedLocation`: Should defines which columns have skewed
values, and should allow us to define storage for each skewed combination of
values. We currently only allow one value per field.
- `AlterTableSetFileFormat`: Should only have one file format, it currently
supports both.
I have implemented all these comments like they were, and I propose to
improve them in follow-up PRs.
#### How was this patch tested?
The existing DDLCommandSuite.
cc @rxin @andrewor14 @yhuai
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hvanhovell/spark SPARK-14086
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12011.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12011
----
commit f7c8eb5bca073d521d0f306e740cbc872cbc657e
Author: Herman van Hovell <hvanhov...@questtec.nl>
Date: 2016-03-28T19:57:20Z
Add DDL commands to SparkSqlParser.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
