Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11961#discussion_r57673061
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -222,19 +222,15 @@ final class RandomForestClassificationModel
private[ml] (
/**
* Estimate of the importance of each feature.
*
- * This generalizes the idea of "Gini" importance to other losses,
- * following the explanation of Gini importance from "Random Forests"
documentation
- * by Leo Breiman and Adele Cutler, and following the implementation
from scikit-learn.
+ * Each feature's importance is the average of its importance across all
trees in the ensemble
+ * The importance vector is normalized to sum to 1. This method is
suggested by Friedman
+ * (J. H. Friedman, "Greedy Function Approximation: A Gradient Boosting
Machine", 1999)
--- End diff --
Nice, SGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
