Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12023#discussion_r57674668
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala ---
    @@ -238,3 +238,128 @@ private[ml] object DecisionTreeModelReadWrite {
         finalNodes.head
       }
     }
    +
    +private[ml] object RandomForestModelReadWrite {
    +
    +  /**
    +    * Info for a [[org.apache.spark.ml.tree.Split]]
    +    *
    +    * @param featureIndex  Index of feature split on
    +    * @param leftCategoriesOrThreshold  For categorical feature, set of 
leftCategories.
    +    *                                   For continuous feature, threshold.
    +    * @param numCategories  For categorical feature, number of categories.
    +    *                       For continuous feature, -1.
    +    */
    +  case class SplitData(
    --- End diff --
    
    Why is this copied here?  Can you reuse the existing SplitData?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to