Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12032#discussion_r57729876
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingPage.scala ---
@@ -241,24 +241,24 @@ private[ui] class StreamingPage(parent: StreamingTab)
// Use the max input rate for all InputDStreams' graphs to make the Y
axis ranges same.
// If it's not an integral number, just use its ceil integral number.
- val maxEventRate =
eventRateForAllStreams.max.map(_.ceil.toLong).getOrElse(0L)
- val minEventRate = 0L
+ val maxRecordRate =
recordRateForAllStreams.max.map(_.ceil.toLong).getOrElse(0L)
+ val minRecordRate = 0L
val batchInterval = UIUtils.convertToTimeUnit(listener.batchDuration,
normalizedUnit)
val jsCollector = new JsCollector
- val graphUIDataForEventRateOfAllStreams =
+ val graphUIDataForRecordRateOfAllStreams =
new GraphUIData(
- "all-stream-events-timeline",
- "all-stream-events-histogram",
- eventRateForAllStreams.data,
+ "all-stream-records-timeline",
--- End diff --
The other changes seem OK as they're to labels and private classes and
internal code; this changes a div ID and I'm not clear if something else has to
change in the code to match? like will something else fail because it doesn't
find all-stream-events-timeline? I don't see any other references though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
