Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12044#discussion_r57803232
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -49,8 +49,11 @@ private class CodeFormatter {
private var currentLine = 1
private def addLine(line: String): Unit = {
- val indentChange =
+ val indentChange = if (line.startsWith("/*") || line.startsWith("//"))
{
--- End diff --
I've updated the PR to support basic multi-line comments and added relevant
tests. We can probably do fancier things if we'd like to support inline
comments (`// hello world /*`) or nested comments, but that's probably not
needed here (and should ideally require a standard parser)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
