Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12047#discussion_r57807341
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -224,9 +224,13 @@ public ColumnarBatch resultBatch() {
/**
* Can be called before any rows are returned to enable returning
columnar batches directly.
+ *
+ * @param maxColumns The maximum number of fields supported by whole
stage codegen.
*/
- public void enableReturningBatches() {
- returnColumnarBatch = true;
+ public boolean tryEnableReturningBatches(int maxColumns) {
--- End diff --
Why are we pushing a config value into the reader so that it can switch?
Can't we just put this logic in the query planner where the decision to call
`enableReturningBatches` is. I think its clearer if there is a single place
where we decide to use column batches or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
