Github user koertkuipers commented on a diff in the pull request:
https://github.com/apache/spark/pull/11980#discussion_r57829829
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -120,17 +120,19 @@ object RowEncoder {
case StructType(fields) =>
val convertedFields = fields.zipWithIndex.map { case (f, i) =>
- val method = if (f.dataType.isInstanceOf[StructType]) {
- "getStruct"
+ val x = extractorsFor(
+ GetExternalRowField(inputObject, i,
externalDataTypeForInput(f.dataType), f.nullable),
+ f.dataType
+ )
+ if (f.nullable) {
+ If(
--- End diff --
i had that before (basically without the If, since GetExternalRowField
already does null checks inside), but the issue is that extractorsFor code path
then also runs for nulls , and that causes some weird runtime errors. i will
try again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
