Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12016#discussion_r57875117
--- Diff:
core/src/test/scala/org/apache/spark/partial/SumEvaluatorSuite.scala ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.partial
+
+
+import org.apache.spark._
+import org.apache.spark.util.StatCounter
+
+class SumEvaluatorSuite extends SparkFunSuite with SharedSparkContext {
+
+ test("correct handling of count 1") {
+
+ //setup
+ val counter = new StatCounter(List(2.0))
+ // count of 10 because it's larger than 1,
+ // and 0.95 because that's the default
+ val evaluator = new SumEvaluator(10, 0.95)
+ // arbitrarily assign id 1
+ evaluator.merge(1, counter)
+
+ //execute
+ val res = evaluator.currentResult()
+ // Build version with known precisions for equality check
+ val round_res = new BoundedDouble(res.mean.round.toDouble,
res.confidence, res.low, res.high)
--- End diff --
By that logic lots of things returning floating point values would be
untestable, but they are. You are asserting that the value returned is the
expected closest-possible double. This is the best course. This test asserts
anything that rounds to the same int is fine, but that's unnecessarily coarse,
and we have clearer syntax for it. If it's really called for, asserting
approximate equality is better.
This should be a conceptually simple fix plus tests, so I'd prefer to head
straight at the simple solution and wrap this up, or else it may be simpler to
merge https://github.com/apache/spark/pull/11981 with a test instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
