Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12071#discussion_r57971100
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -1,749 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.spark.sql.hive
-
-import java.util.Locale
-
-import scala.collection.JavaConverters._
-
-import org.apache.hadoop.hive.common.`type`.HiveDecimal
-import org.apache.hadoop.hive.conf.HiveConf
-import org.apache.hadoop.hive.conf.HiveConf.ConfVars
-import org.apache.hadoop.hive.ql.exec.{FunctionInfo, FunctionRegistry}
-import org.apache.hadoop.hive.ql.parse.EximUtil
-import org.apache.hadoop.hive.ql.session.SessionState
-import org.apache.hadoop.hive.serde.serdeConstants
-import org.apache.hadoop.hive.serde2.`lazy`.LazySimpleSerDe
-
-import org.apache.spark.internal.Logging
-import org.apache.spark.sql.catalyst.catalog._
-import org.apache.spark.sql.catalyst.expressions._
-import org.apache.spark.sql.catalyst.parser._
-import org.apache.spark.sql.catalyst.plans._
-import org.apache.spark.sql.catalyst.plans.logical._
-import org.apache.spark.sql.execution.SparkQl
-import org.apache.spark.sql.hive.HiveShim.HiveFunctionWrapper
-import org.apache.spark.sql.hive.execution._
-import org.apache.spark.sql.types._
-import org.apache.spark.sql.AnalysisException
-
-/**
- * Used when we need to start parsing the AST before deciding that we are
going to pass the command
- * back for Hive to execute natively. Will be replaced with a native
command that contains the
- * cmd string.
- */
-private[hive] case object NativePlaceholder extends LogicalPlan {
- override def children: Seq[LogicalPlan] = Seq.empty
- override def output: Seq[Attribute] = Seq.empty
-}
-
-private[hive] case class CreateTableAsSelect(
- tableDesc: CatalogTable,
- child: LogicalPlan,
- allowExisting: Boolean) extends UnaryNode with Command {
-
- override def output: Seq[Attribute] = Seq.empty[Attribute]
- override lazy val resolved: Boolean =
- tableDesc.identifier.database.isDefined &&
- tableDesc.schema.nonEmpty &&
- tableDesc.storage.serde.isDefined &&
- tableDesc.storage.inputFormat.isDefined &&
- tableDesc.storage.outputFormat.isDefined &&
- childrenResolved
-}
-
-private[hive] case class CreateViewAsSelect(
- tableDesc: CatalogTable,
- child: LogicalPlan,
- allowExisting: Boolean,
- replace: Boolean,
- sql: String) extends UnaryNode with Command {
- override def output: Seq[Attribute] = Seq.empty[Attribute]
- override lazy val resolved: Boolean = false
-}
-
-/** Provides a mapping from HiveQL statements to catalyst logical plans
and expression trees. */
-private[hive] class HiveQl(conf: ParserConf) extends SparkQl(conf) with
Logging {
- import ParseUtils._
- import ParserUtils._
-
- // Token text -> human readable text
- private val hiveUnsupportedCommands = Map(
- "TOK_CREATEROLE" -> "CREATE ROLE",
- "TOK_DROPROLE" -> "DROP ROLE",
- "TOK_EXPORT" -> "EXPORT TABLE",
- "TOK_GRANT" -> "GRANT",
- "TOK_GRANT_ROLE" -> "GRANT",
- "TOK_IMPORT" -> "IMPORT TABLE",
- "TOK_REVOKE" -> "REVOKE",
- "TOK_REVOKE_ROLE" -> "REVOKE",
- "TOK_SHOW_COMPACTIONS" -> "SHOW COMPACTIONS",
- "TOK_SHOW_CREATETABLE" -> "SHOW CREATE TABLE",
- "TOK_SHOW_GRANT" -> "SHOW GRANT",
- "TOK_SHOW_ROLE_GRANT" -> "SHOW ROLE GRANT",
- "TOK_SHOW_ROLE_PRINCIPALS" -> "SHOW PRINCIPALS",
- "TOK_SHOW_ROLES" -> "SHOW ROLES",
- "TOK_SHOW_SET_ROLE" -> "SHOW CURRENT ROLES / SET ROLE",
- "TOK_SHOW_TRANSACTIONS" -> "SHOW TRANSACTIONS",
- "TOK_SHOWINDEXES" -> "SHOW INDEXES",
- "TOK_SHOWLOCKS" -> "SHOW LOCKS")
--- End diff --
It will produce the same error message, with the same nice message. See:
https://github.com/hvanhovell/spark/blob/SPARK-14211/sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala#L84-L93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
