Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12057#discussion_r57977976
  
    --- Diff: python/pyspark/worker.py ---
    @@ -107,21 +149,10 @@ def main(infile, outfile):
                     _broadcastRegistry.pop(bid)
     
             _accumulatorRegistry.clear()
    -        row_based = read_int(infile)
    -        num_commands = read_int(infile)
    -        if row_based:
    -            profiler = None  # profiling is not supported for UDF
    -            row_func = None
    -            for i in range(num_commands):
    -                f, returnType, deserializer = read_command(pickleSer, 
infile)
    -                if row_func is None:
    -                    row_func = f
    -                else:
    -                    row_func = chain(row_func, f)
    -            serializer = deserializer
    -            func = lambda _, it: map(lambda x: 
returnType.toInternal(row_func(*x)), it)
    +        is_udf = read_int(infile)
    +        if is_udf:
    --- End diff --
    
    I'd _maybe_ call this `is_sql_udf` just to make it clearer that this is 
part of PySpark SQL support, but I don't feel strongly about this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to