Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12057#discussion_r57993562
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
 ---
    @@ -59,45 +60,43 @@ private[spark] object ExtractPythonUDFs extends 
Rule[LogicalPlan] {
     
         case plan: LogicalPlan if plan.resolved =>
           // Extract any PythonUDFs from the current operator.
    -      val udfs = plan.expressions.flatMap(collectEvaluatableUDF)
    +      val udfs = 
plan.expressions.flatMap(collectEvaluatableUDF).filter(_.resolved)
    --- End diff --
    
    I think so, since the plan is already resolved. Just keeping them here for 
safe (it exists before my change)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to