Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12040#discussion_r58118885
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
    @@ -920,7 +931,7 @@ private[execution] object AggregateProcessor {
         // Create the projections.
         val initialProjection = newMutableProjection(
           initialValues,
    -      Seq(SizeBasedWindowFunction.n))()
    +      Seq(partitionSize))()
    --- End diff --
    
    The actual buffer will have more values, right? We always put partitionSize 
at the first value? Or, if we do not have a sized based function, we will later 
set the first value again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to