Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58282614
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -67,9 +70,14 @@ class SimpleFunctionRegistry extends FunctionRegistry {
}
override def lookupFunction(name: String, children: Seq[Expression]):
Expression = {
+ val builder = functionBuilders.get(name)
+ if (builder.isEmpty) {
+ throw new AnalysisException(s"undefined function $name")
+ }
val func = synchronized {
- functionBuilders.get(name).map(_._2).getOrElse {
- throw new AnalysisException(s"undefined function $name")
+ Try(builder.map(_._2)) match {
--- End diff --
I still don't understand why this needs to be changed. This is just calling
`Option.map` and then getting the second field, which is what the old code does
as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
