Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/12133#discussion_r58307196 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -238,16 +238,20 @@ class SparkSqlAstBuilder extends AstBuilder { ctx.tableProperty.asScala.map { property => // A key can either be a String or a collection of dot separated elements. We need to treat // these differently. - val key = if (property.key.STRING != null) { - string(property.key.STRING) - } else { - property.key.getText - } + val key = visitTablePropertyKey(property.key) val value = Option(property.value).map(string).orNull key -> value }.toMap } + override def visitTablePropertyKey(key: TablePropertyKeyContext): String = { --- End diff -- Could you add a little bit of documentation for this method. The comment on line 239 is a good starting point.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org