Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12133#discussion_r58308812
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala 
---
    @@ -374,6 +374,52 @@ case class ShowDatabasesCommand(databasePattern: 
Option[String]) extends Runnabl
     }
     
     /**
    + * A command for users to list the properties for a table.
    + * If propertyKey is specified, the value for the propertyKey
    + * is returned. If propertyKey is not specified, all the keys
    + * and their corresponding values are returned.
    + * The syntax of using this command in SQL is:
    + * {{{
    + *   SHOW TBLPROPERTIES table_name[('propertyKey')];
    + * }}}
    + */
    +case class ShowTablePropertiesCommand(
    +    table: TableIdentifier,
    +    propertyKey: Option[String]) extends RunnableCommand {
    +
    +  override val output: Seq[Attribute] = {
    +    val withKeySchema: Seq[Attribute] = {
    +      AttributeReference("value", StringType, nullable = false)() :: Nil
    +    }
    +    val noKeySchema: Seq[Attribute] = {
    +      AttributeReference("key", StringType, nullable = false)() ::
    +        AttributeReference("value", StringType, nullable = false)() :: Nil
    +    }
    +    propertyKey.map(p => withKeySchema).getOrElse(noKeySchema)
    +  }
    +
    +  override def run(sqlContext: SQLContext): Seq[Row] = {
    +    val catalog = sqlContext.sessionState.catalog
    +
    +    if (catalog.isTemporaryTable(table)) {
    +      throw new AnalysisException("This operation is unsupported for 
temporary tables")
    +    }
    +    val catalogTable = sqlContext.sessionState.catalog.getTable(table)
    --- End diff --
    
    Its documented [here] 
(https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala#L28-L35)
 
    
    Its good to also add it in the SessionCatalog.getTable doc. I will add a 
comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to