Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12067#discussion_r58327554
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala ---
@@ -43,52 +43,52 @@ import
org.apache.spark.sql.execution.aggregate.TypedAggregateExpression
*
* Based loosely on Aggregator from Algebird:
https://github.com/twitter/algebird
*
- * @tparam I The input type for the aggregation.
- * @tparam B The type of the intermediate value of the reduction.
- * @tparam O The type of the final output result.
+ * @tparam Input The input type for the aggregation.
+ * @tparam Buffer The type of the intermediate value of the reduction.
+ * @tparam Result The type of the final output result.
* @since 1.6.0
*/
-abstract class Aggregator[-I, B, O] extends Serializable {
+abstract class Aggregator[-Input, Buffer, Result] extends Serializable {
--- End diff --
maybe IN, BUF, and OUT
we have mostly used upper case type parameters in Spark.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
