Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58332876
--- Diff:
core/src/main/java/org/apache/spark/api/java/function/MapFunction.java ---
@@ -23,5 +23,5 @@
* Base interface for a map function used in Dataset's map function.
*/
public interface MapFunction<T, U> extends Serializable {
- U call(T value) throws Exception;
--- End diff --
These function APIs will be implemented by users and called by us, why do
we declare it to throw exceptions? It brings a lot of trouble when using it in
codegen, but seems no benefit? cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
