Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11989#discussion_r58340397
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -360,7 +362,8 @@ private[ml] trait RandomForestParams extends
TreeEnsembleParams {
"The number of features to consider for splits at each tree node." +
s" Supported options:
${RandomForestParams.supportedFeatureSubsetStrategies.mkString(", ")}",
(value: String) =>
-
RandomForestParams.supportedFeatureSubsetStrategies.contains(value.toLowerCase))
+
RandomForestParams.supportedFeatureSubsetStrategies.contains(value.toLowerCase)
+ || value.matches("^(?:[1-9]\\d*|0\\.\\d*[1-9]\\d*\\d*|1\\.0+)$"))
--- End diff --
This regex is repeated twice, does it perhaps make sense to move it to a
constant (would have to be `private[spark]` probably to enable `mllib` package
to read it). @sethah what do you think about that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
