Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12020#discussion_r58419248
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
@@ -198,6 +202,11 @@ class TrainValidationSplitModel private[ml] (
@Since("1.5.0") val validationMetrics: Array[Double])
extends Model[TrainValidationSplitModel] with TrainValidationSplitParams
with MLWritable {
+ /** A Java/Python-friendly auxiliary constructor. */
--- End diff --
If this is intended to be Java friendly then we probably don't want to make
it private to ML scope and we should expand on the javadoc. If it is just for
Python it seems this would probably be better suited to PythonMLLibAPI.scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
