Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58454715
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog(
*/
def dropFunction(name: FunctionIdentifier): Unit = {
val db = name.database.getOrElse(currentDb)
+ val qualified = name.copy(database = Some(db)).unquotedString
+ if (functionRegistry.functionExists(qualified)) {
+ // If we have loaded this function into FunctionRegistry,
+ // also drop it from there.
+ functionRegistry.dropFunction(qualified)
--- End diff --
I don't understand why we have to do this. Isn't the function registry only
for temporary functions? We only put things in it in `createTempFunction`, so
we just only remove things from it in `dropTempFunction`. This method here is
for persistent functions only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
