Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11621#discussion_r58467127
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
    @@ -539,6 +539,10 @@ class LinearRegressionTrainingSummary 
private[regression] (
      * Linear regression results evaluated on a dataset.
      *
      * @param predictions predictions outputted by the model's `transform` 
method.
    + * @param predictionCol Field in "predictions" which gives the predicted 
value of the label at
    + *                      each instance.
    + * @param labelCol Field in "predictions" which gives the true label of 
each instance
    + *                 (if available).
    --- End diff --
    
    Hmm, good point; "if available" only makes sense for the generic summary 
classes, not the *TrainingSummary classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to