Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1551#discussion_r15569391
  
    --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala 
---
    @@ -344,7 +345,12 @@ private[spark] object PythonRDD extends Logging {
                   throw new SparkException("Unexpected Tuple2 element type " + 
pair._1.getClass)
               }
             case other =>
    -          throw new SparkException("Unexpected element type " + 
first.getClass)
    +          if (other == null) {
    +            dataOut.writeInt(SpecialLengths.NULL)
    +            writeIteratorToStream(iter, dataOut)
    --- End diff --
    
    BTW apart from the stability issue above with catching our own bugs, the 
reason I'm commenting is that this change also adds some moderately tricky code 
in a fairly important code path, increasing the chance of adding new bugs. That 
doesn't seem worth it to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to