Github user Colin-Yu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12154#discussion_r58483960
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1360,6 +1360,16 @@ class SparkContext(config: SparkConf) extends
Logging with ExecutorAllocationCli
listenerBus.addListener(listener)
}
+ private[spark] override def getExecutorIds(): Seq[String] = {
--- End diff --
A newbie question: if a method has no side effect and return values, do
code standard in spark suggest to remove parenthesis in method declaration?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
