Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/12141#discussion_r58486779
--- Diff: R/pkg/inst/tests/testthat/test_context.R ---
@@ -36,7 +36,7 @@ test_that("Check masked functions", {
any(grepl("=\"ANY\"",
capture.output(showMethods(x)[-1])))
}))
maskedCompletely <- masked[!funcHasAny]
- namesOfMaskedCompletely <- c("cov", "filter", "sample")
+ namesOfMaskedCompletely <- c("cov", "filter", "sample", "window")
--- End diff --
if this fails that means the current definition will block the
stats::window function completely, (ie. user will not be able to call it
without altering the code with stats:: prefix)
this is in fact delibrate - to avoid masking the function by accident. for
instance, please set the generic (in R/pkg/R/generics.R) as `window(x, ...)` to
match the stats package definition - generally that would allow both to be
called at the same time.
@sun-rui @shivaram
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
