Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/12123#issuecomment-205648608
LGTM but we should consider the case of using HistoryServer.
When we use HistoryServer, SparkContext is not defined so the user name
should be always `<unknown>`.
You can use REST based status API to get the user name even though we use
HistoryServer.
Supporting HistoryServer can be separated from this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
