Github user joan38 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12157#discussion_r58514424
  
    --- Diff: core/src/main/scala/org/apache/spark/Partition.scala ---
    @@ -26,6 +26,11 @@ trait Partition extends Serializable {
        */
       def index: Int
     
    +  override def equals(other: Any): Boolean = other match {
    +    case that: Partition => super.equals(that) && that.index == index
    --- End diff --
    
    If so, do you mean using the `canEqual` approach?
    If not, do you mean removing both `equals` and `hashCode` then?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to