Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r58553056
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -440,12 +440,9 @@ final class OnlineLDAOptimizer extends LDAOptimizer {
val stat = BDM.zeros[Double](k, vocabSize)
var gammaPart = List[BDV[Double]]()
nonEmptyDocs.foreach { case (_, termCounts: Vector) =>
- val ids: List[Int] = termCounts match {
- case v: DenseVector => (0 until v.size).toList
- case v: SparseVector => v.indices.toList
- }
+ val ids: List[Int] = LDAUtils.vectorAsList(termCounts)
--- End diff --
Yes I agree. It is better to simply return `ids` rather than having callers
to compute it. I will make that change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
